Detect Wayland or X11 displays before choosing text UI #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, Unison will not start its graphical interface when running in a pure-Wayland environment.
tleedjarv
reviewed
Nov 17, 2022
|
I am conceptually ok with this and will let you two resolve the ocaml style issues. In the glorious future, we'll have unison and unison-gui, which I think won't do this, but in the meantime this seems to extend in the right way. |
|
It looks like this needs != converted to <> at least. @mxmgh are you ok with the suggested change? If you so you push the commit suggestion button, or redo the branch yourself. |
Co-authored-by: Tõivo Leedjärv <69477666+tleedjarv@users.noreply.github.com>
|
I can't test this but the code looks fine. Squash the commits (no need to keep the Co-authored-by tag), or @gdt you can also do it when merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, Unison will not start its graphical interface when running in a pure-Wayland environment.