Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom setting to control automatic project discovery #1539

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Add a custom setting to control automatic project discovery #1539

merged 1 commit into from
Jun 15, 2020

Conversation

fishyfriend
Copy link
Contributor

@fishyfriend fishyfriend commented May 23, 2020

This PR adds a custom setting projectile-auto-discover that controls whether to automatically run projectile-discover-projects-in-search-path when Projectile mode is activated.

The main purpose is to enable faster Emacs startup when starting projectile-mode automatically from the init file. On my system (~2015 i5, Emacs 27, Linux, with 140 project directories) turning off auto-discovery improves startup time by around 1.7 seconds.

The default setting for projectile-auto-discover leaves current behavior unchanged.

One already has to manually run one of the projectile-discover-* commands to update project bookmarks during an Emacs session, so it seems reasonable to allow the user to choose to always use manual updating rather than forcing an update every time they start Emacs or turn on the mode. Since project bookmarks are cached and loaded from disk, it's usually not necessary to update them anyway.

The following tests are failing on master on my machine so I don't think the failures are related to my changes. All other tests are passing.

  • "projectile-grep multi-root grep grep multi-root projects"
  • "projectile-compilation-dir should not fail on bad compilation dir config"

Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@bbatsov bbatsov merged commit 10bd27d into bbatsov:master Jun 15, 2020
@bbatsov
Copy link
Owner

bbatsov commented Jun 15, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants