Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a prefix argument to projectile-vc #1228

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Add support for a prefix argument to projectile-vc #1228

merged 2 commits into from
Mar 22, 2018

Conversation

knu
Copy link
Contributor

@knu knu commented Mar 22, 2018

This makes C-u M-x projectile-vc prompt you for a project directory to open.

It currently simply ignores a prefix argument that is interactively given.

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

@bbatsov bbatsov merged commit bafd7d6 into bbatsov:master Mar 22, 2018
@bbatsov
Copy link
Owner

bbatsov commented Mar 22, 2018

Seems like a reasonable addition to me. 👍

@knu knu deleted the projectile-vc-prefix-arg branch March 22, 2018 11:43
@cocreature
Copy link

This PR seems to have resulted in C-p v always asking for a project name instead of only when a prefix argument is passed. My elisp foo is sadly quite weak but looking at the source I can’t find anything that checks for the prefix argument while other functions such as projectile-invalidate-cache do seem to check explicitely for the argument.

Am I missing something here or is this a bug?

BTW, keep up the great work, projectile is a joy to use!

@knu
Copy link
Contributor Author

knu commented Mar 23, 2018

@cocreature Thanks for the catch! I now realized &optional and (interactive ...) don't really go well. I'll file another PR to address the problem.

@knu knu mentioned this pull request Mar 23, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knu @bbatsov @cocreature