Bump to rules_proto 6.0.2, separate protobuf 21.7 #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI still only failing on Bazel green head again. Still don't know why this presumably optional run is failing the build now. Also, because I forgot earlier, I meant to cc: @BillyAutrey @jayconrod @benjaminp @TheGrizzlyDev |
mbland
added a commit
to mbland/rules_scala
that referenced
this pull request
Oct 17, 2024
Depends on the rules_proto 6.0.2 bump from bazelbuild#1623. This is another measure to preemptively avoid a warning under Bzlmod that a dependency uses a newer version or rules_go.
mbland
added a commit
to mbland/rules_scala
that referenced
this pull request
Oct 17, 2024
Depends on the rules_proto 6.0.2 bump from bazelbuild#1623. This is another measure to preemptively avoid a warning under Bzlmod that a dependency uses a newer version of rules_go.
This is in preparation for adding a `MODULE.bazel` file, which will bring in dependencies that use rules_proto 6.x. This change avoids that warning, and changing it now ensures that `WORKSPACE` builds are still compatible. As explained in the 6.0.0 release notes, rules_proto 6.x no longer depends directly on com_google_protobuf, so we need to import it separately. We're keeping the Protobuf version as 21.7 for now, because Protobuf 22.x requires C++14 at a minimum, which Bazel 6.x doesn't support by default: - https://protobuf.dev/news/v22/#c11-support - https://github.com/protocolbuffers/protobuf/releases/tag/v22.0 The downside is that, unline rules_proto-5.3.0-21.7, we now end up building (and occasionally rebuilding) `protoc` as part of our build. However, this also enables clients to try "Protobuf Toolchainization" to download precompiled `protoc` binaries. - https://github.com/bazelbuild/rules_proto/releases/tag/6.0.0 - https://docs.google.com/document/d/1CE6wJHNfKbUPBr7-mmk_0Yo3a4TaqcTPE0OWNuQkhPs/edit For now, Protobuf Toolchainization requires Bazel 6.5.0 or Bazel >= 7 and the `--incompatible_enable_proto_toolchain_resolution` flag: - https://bazel.build/reference/command-line-reference#flag--incompatible_enable_proto_toolchain_resolution I've got a working draft implementation in a separate branch, though that experiment is certainly not urgent.
I'd previously checked for an existing `protobuf` rule, not `com_google_protobuf`. D'oh!
mbland
force-pushed
the
bzlmod-update-rules-proto
branch
from
babdf42 to
ee22e92
Compare
|
Rebased and passing after #1627, including latest Bazel 7.3.2. |
liucijus
approved these changes
Oct 23, 2024
Heh, on the one hand, this experience has taught my why On the other, I've yet to try it, but I think I can introduce an API shared between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the build to depend on rules_proto 6.0.2, and the now separate protobuf v21.7.
Part of #1482.
As explained in the 6.0.0 release notes, rules_proto 6.x no longer depends directly on com_google_protobuf, so we need to import it separately. We're keeping the Protobuf version as 21.7 for now, because Protobuf 22.x requires C++14 at a minimum, which Bazel 6.x doesn't support by default:
The downside is that, unline rules_proto-5.3.0-21.7, we now end up building (and occasionally rebuilding)
protocas part of our build.Motivation
This is in preparation for adding a
MODULE.bazelfile, which will bring in dependencies that use rules_proto 6.x. This change avoids that warning, and changing it now ensures thatWORKSPACEbuilds are still compatible.The flip side of the downside is that rules_proto 6.0.2 also enables clients to try "Protobuf Toolchainization" to download precompiled
protocbinaries.For now, Protobuf Toolchainization requires Bazel 6.5.0 or Bazel >= 7 and the
--incompatible_enable_proto_toolchain_resolutionflag:I've got a working draft implementation of proto toolchainization in a separate branch, though that experiment is certainly not urgent.