Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable buildifier presubmit check #245

Merged
merged 8 commits into from
Oct 23, 2019
Merged

Enable buildifier presubmit check #245

merged 8 commits into from
Oct 23, 2019

Conversation

hlopko
Copy link
Member

@hlopko hlopko commented Oct 23, 2019 •
edited
Loading

This PR enables all buildifier checks on presubmit, plus it migrates the repo to fix violations.

@hlopko hlopko requested a review from brandjon October 23, 2019 08:21
@hlopko hlopko marked this pull request as ready for review October 23, 2019 08:21
@hlopko hlopko requested a review from lberki as a code owner October 23, 2019 08:21
brandjon
brandjon requested changes Oct 23, 2019
View reviewed changes
Copy link
Member

@brandjon brandjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll integrate my comments...

experimental/python/wheel.bzl Outdated Show resolved Hide resolved
python/defs.bzl Show resolved Hide resolved
python/private/reexports.bzl Outdated Show resolved Hide resolved
@brandjon brandjon merged commit 230f6d1 into bazelbuild:master Oct 23, 2019
@brandjon
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lberki lberki lberki approved these changes

@brandjon brandjon brandjon approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlopko @brandjon @lberki @googlebot