Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #237

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Update README #237

merged 2 commits into from
Oct 9, 2019

Conversation

brandjon
Copy link
Member

@brandjon brandjon commented Oct 9, 2019

Expand the Overview. Add more context on core rules vs packaging rules and
level of support. Add instructions for using Bazel Federation. Move pip stuff
to sub-headings.

Fixes #229.

Expand the Overview. Add more context on core rules vs packaging rules and
level of support. Add instructions for using Bazel Federation. Move pip stuff
to sub-headings.
@brandjon brandjon requested a review from lberki as a code owner October 9, 2019 03:37
@brandjon brandjon self-assigned this Oct 9, 2019
@brandjon brandjon requested review from aiuto and removed request for lberki October 9, 2019 03:42
@brandjon
Copy link
Member Author

brandjon commented Oct 9, 2019

Setting Tony as reviewer, but I'm going to force submit in the interest of getting a release out tonight since I'm OOO tomorrow. Feel free to leave me comments to forward-fix afterwards.

@brandjon
Copy link
Member Author

brandjon commented Oct 9, 2019

It looks kind of strange that the WORKSPACE boilerplate produced by the //distro:relnotes target doesn't mention the federation at all. Is that because it's expected that py_repositories would load the federation? It doesn't, but that's because our distributable has no other repos as dependencies.

@brandjon brandjon merged commit 9150caa into bazelbuild:master Oct 9, 2019
@brandjon brandjon deleted the readme branch October 9, 2019 03:54
Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
brandjon added a commit to brandjon/rules_python that referenced this pull request Oct 10, 2019
Follow-up to bazelbuild#237. Moves development workflow info to CONTRIBUTING.md. Fixes
the instructions for how to use the Bazel Federation.

Also updates the project WORKSPACE to use a released version of the Federation.
@brandjon brandjon mentioned this pull request Oct 10, 2019
@brandjon
Copy link
Member Author

See #239 for post-merge fixes.

brandjon added a commit that referenced this pull request Oct 18, 2019
Follow-up to #237. Moves development workflow info to CONTRIBUTING.md. Fixes
the instructions for how to use the Bazel Federation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status of rules_python
3 participants