Expand CI coverage to detect #225 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandjon
force-pushed
the
fix-filtering
branch
from
79d03f8 to
bc34490
Compare
|
Related: #225 |
lberki
approved these changes
Aug 16, 2019
brandjon
force-pushed
the
fix-filtering
branch
from
bc34490 to
9c31f1b
Compare
|
Rebasing on 37cdefa. |
brandjon
added a commit
to brandjon/bazel-federation
that referenced
this pull request
Sep 3, 2019
This rolls back bazelbuild#45, now that bazelbuild/rules_python#225 has been fixed. CI coverage for the failure has also been added to rules_python in bazelbuild/rules_python#226.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expecting CI to fail if I did this right, then we can modify this PR to include the fix.