Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the temporary directory containing cacert.pem when done #169

Merged
merged 2 commits into from
Aug 1, 2019

Conversation

AustinSchuh
Copy link
Contributor

Our verification machines were filling up /tmp/ with this temporary
folder. This patch removes it when piptool exits.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 3, 2019
@AustinSchuh
Copy link
Contributor Author

Ping?

@aiuto
Copy link
Contributor

aiuto commented May 21, 2019

The change seems fine. I am having trouble running the .par files.

@AustinSchuh
Copy link
Contributor Author

Thanks @aiuto . The .par files work for me, which isn't particularly helpful here. Do you want me to try re-building them? Or something else?

@brandjon
Copy link
Member

On the face of it the change looks reasonable, but I don't think we want to merge updates to the checked-in par files unless they come from a trusted source (#184). In the meantime I suppose I can run update_tools.sh and append to the commit history on the PR branch.

@AustinSchuh
Copy link
Contributor Author

@brandjon , works for me. You should be able to update this PR.

@AustinSchuh
Copy link
Contributor Author

Ping, any update?

@AustinSchuh
Copy link
Contributor Author

Is there any way I can help get this merged? It's been sitting here for 2 months.

@rogerhub
Copy link

rogerhub commented Aug 1, 2019

Can we merge just the python part without the .par changes? That might let us submit this faster.

@AustinSchuh
Copy link
Contributor Author

@brandjon , would that work? I'm happy to do whatever to keep this moving.

Our verification machines were filling up /tmp/ with this temporary
folder.  This patch removes it when piptool exits.
@brandjon
Copy link
Member

brandjon commented Aug 1, 2019

Hi Austin, I'm rebasing your branch with the par files regenerated on my system. Will merge shortly.

@brandjon brandjon merged commit d0191f0 into bazelbuild:master Aug 1, 2019
@AustinSchuh
Copy link
Contributor Author

Wohoo! Thanks @brandjon

fweikert pushed a commit to fweikert/rules_python that referenced this pull request Aug 7, 2019
…build#169)

Our verification machines were filling up /tmp/ with this temporary
folder.  This patch removes it when piptool exits.
@AustinSchuh AustinSchuh deleted the tmpcleanup branch April 14, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants