-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the temporary directory containing cacert.pem when done #169
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Ping? |
The change seems fine. I am having trouble running the .par files. |
Thanks @aiuto . The .par files work for me, which isn't particularly helpful here. Do you want me to try re-building them? Or something else? |
On the face of it the change looks reasonable, but I don't think we want to merge updates to the checked-in par files unless they come from a trusted source (#184). In the meantime I suppose I can run update_tools.sh and append to the commit history on the PR branch. |
@brandjon , works for me. You should be able to update this PR. |
Ping, any update? |
Is there any way I can help get this merged? It's been sitting here for 2 months. |
Can we merge just the python part without the .par changes? That might let us submit this faster. |
@brandjon , would that work? I'm happy to do whatever to keep this moving. |
Our verification machines were filling up /tmp/ with this temporary folder. This patch removes it when piptool exits.
Hi Austin, I'm rebasing your branch with the par files regenerated on my system. Will merge shortly. |
Wohoo! Thanks @brandjon |
…build#169) Our verification machines were filling up /tmp/ with this temporary folder. This patch removes it when piptool exits.
Our verification machines were filling up /tmp/ with this temporary
folder. This patch removes it when piptool exits.