Force lower case on Bazel pkg path to play nice with oci container name spec #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repository name (https://github.com/opencontainers/distribution-spec/blob/main/spec.md#pulling-manifests), this doesn't bode well with Bazel package path using upper case. To be clear: docker itself is ok with upper case: https://ktomk.github.io/pipelines/doc/DOCKER-NAME-TAG.html. Picking the common denominator here, and force lower case on pkg path.
sfc-gh-bxin
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
linzhp
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCI distribution spec only allows lower case letter in container repository name
(https://github.com/opencontainers/distribution-spec/blob/main/spec.md#pulling-manifests), this doesn't bode well with Bazel package path using upper case.
Relevant docker spec on 'repository name' scheme: https://github.com/moby/moby/blob/master/image/spec/v1.2.md. Among other things: "...Name components may contain lowercase characters, digits, and separators...."
So force lower case on pkg path.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
<bazel_ws>/Pkg_path_with_upper_case/ $ bazel build <:container_image_target.tar>
...
FAILED: Build did NOT complete successfully
...
Unable to process values passed using the flag --tag: unable to parse stamped image name "bazel/Pkg_path_with_upper_case:container_image_target" as a fully qualified image reference: repository can only contain the runes
abcdefghijklmnopqrstuvwxyz0123456789_-./: bazel/Pkg_path_with_upper_caseIssue Number: N/A
What is the new behavior?
bazel builds successfully.
Does this PR introduce a breaking change?
Other information