Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label override provided by custom container_image rules #2233

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Fix label override provided by custom container_image rules #2233

merged 1 commit into from
Mar 16, 2023

Conversation

hamsterstorm
Copy link
Contributor

_image_config was retrieving labels from ctx instead of the
labels arg.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@hamsterstorm
Fix label override provided by custom container_image rules
ca2f308 
_image_config was retrieving labels from ctx instead of the
labels arg.
@hamsterstorm hamsterstorm marked this pull request as ready for review March 15, 2023 22:54
@linzhp linzhp merged commit 4ad878e into bazelbuild:master Mar 16, 2023
rbielak
rbielak reviewed Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@rbielak rbielak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamsterstorm hamsterstorm deleted the labels_fix branch March 23, 2023 23:21
@faximan faximan mentioned this pull request Apr 17, 2023
Merged
faximan added a commit to googlecloudrobotics/core that referenced this pull request Apr 17, 2023
@faximan
Bump io_bazel_rules_docker (#135)
a185d48 
Pulls in bazelbuild/rules_docker#2233 which is
expected by downstream repos. Looks like rules_docker haven't had a
labelled release in a while, hence the commit reference.

This corresponds to http://cl/517244821.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbielak rbielak rbielak left review comments

@linzhp linzhp linzhp approved these changes

@gravypod gravypod Awaiting requested review from gravypod gravypod is a code owner

@pcj pcj Awaiting requested review from pcj pcj is a code owner

@smukherj1 smukherj1 Awaiting requested review from smukherj1 smukherj1 is a code owner

@uhthomas uhthomas Awaiting requested review from uhthomas uhthomas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamsterstorm @rbielak @linzhp