Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build darwin arm64 to ci workflow #2169

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Build darwin arm64 to ci workflow #2169

merged 2 commits into from
Nov 28, 2022

Conversation

connyay
Copy link
Contributor

@connyay connyay commented Oct 9, 2022

Would like to get apple silicon working natively.
This change would move #2033 along

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Darwin arm64 binaries (puller/loader) are not prebuilt artifacts

Issue Number: Pull #2033

What is the new behavior?

Darwin arm64 binaries (puller/loader) are prebuilt artifacts

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Would like to get apple silicon working natively.
This change would move bazelbuild#2033 along
@connyay
Copy link
Contributor Author

connyay commented Oct 9, 2022

#2033 has been stuck for a bit. #2033 (comment) was the last breadcrumb on how to move it forward.

@connyay
Copy link
Contributor Author

connyay commented Nov 22, 2022

@linzhp / @uhthomas - any chance you could help land this? Having to patch #2033 is newly created repos is getting pretty annoying.

@linzhp
Copy link
Collaborator

linzhp commented Nov 22, 2022

Can you pull from master and see if the CI passes?

@linzhp linzhp merged commit def5c96 into bazelbuild:master Nov 28, 2022
@connyay connyay deleted the patch-1 branch November 28, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants