Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules_pkg to the latest release. #2125

Merged
merged 7 commits into from
Jul 20, 2022
Merged

Conversation

aiuto
Copy link
Contributor

@aiuto aiuto commented Jul 7, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

pkg_tar is being referenced at a legacy location (@rules_pkg//:pkg.bzl) which will go away in a future release of rules_pkg. This PR updates rules_pkg to the latest release and fixes the references to be to the correct location (@rules_pkg//pkg:tar.bzl) which will remain correct indefinitely.

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@uhthomas
Copy link
Collaborator

uhthomas commented Jul 7, 2022

Looks good, though we may be using an old version of rules_pkg by the looks of it.

(14:33:39) ERROR: error loading package 'testdata': Label '@rules_pkg//pkg:tar.bzl' is invalid because 'pkg' is not a package; perhaps you meant to put the colon here: '@rules_pkg//:pkg/tar.bzl'?

@aiuto aiuto changed the title Fix references to pkg_tar to point to the correct location in rules_pkg. Update rules_pkg to the latest release. Jul 12, 2022
@aiuto
Copy link
Contributor Author

aiuto commented Jul 12, 2022

Fixed.
I updated to the latest rules_pkg, and fixed the tests which were depending on the ancient, broken, behavior of adding a '.' folder to every tarball.

@aiuto
Copy link
Contributor Author

aiuto commented Jul 20, 2022

Friendly ping

@linzhp linzhp merged commit 23cd893 into bazelbuild:master Jul 20, 2022
St0rmingBr4in pushed a commit to St0rmingBr4in/rules_docker that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants