Add java_layer rule that allows fine layering of JVM dependencies (like py_layer for Python) #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns476
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
gravypod
approved these changes
Aug 2, 2022
St0rmingBr4in
pushed a commit
to St0rmingBr4in/rules_docker
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no rule that allows fine layering of JVM dependencies (like
py_layer) forjava_images.Issue Number: N/A
What is the new behavior?
JavaInfois forwarded byfilter_layerand there is a rulejava_layerwhich functions identically topy_layerthat allows filtering dependencies.Does this PR introduce a breaking change?
Other information
I wasn't sure that building the merged JavaInfo was the best way to do this, but I think any other way requires some more intrusive changes to
java_image- I tried with an empty JavaInfo and forwarding the JavaInfo (as the code does with PyInfo) and they result in an empty layer and a layer with all dependencies (not filtering them at all) respectively.