Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
As noted in #2099, if you use
container_import
to declare foreign layers, then depend on that in acontainer_image
orcontainer_push
as a whole-image.tar
, you lose the foreign layer URLs, resulting in an invalid image. This is becausecompat/reader.go
loads the foreign image information from the image manifest first, then overwrites that with the empty stub layer found in the tarball. You can observe the loss of information in the resulting image's manifest.This used to work with the Python-language image reader, but broke in the move to the Golang pusher.
Issue Number: #2099
What is the new behavior?
We load the foreign layers last so that the stub information is overwritten.
Does this PR introduce a breaking change?
Other information