Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to non-api fetch URLs #1732

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Switch to non-api fetch URLs #1732

merged 1 commit into from
Aug 11, 2021

Conversation

illicitonion
Copy link
Contributor

This is a no-op change.

These URLs have a few advantages:

  • GitHub is less aggressive at rate-limiting these URLs, and these URLs
    are easier to set up pass-through proxies for in an enterprise
    setting.
  • The URLs self-document which tag is being fetched, rather than
    requiring separate comments to track tags (but the sha256 ensures
    re-pointed tags will still halt builds). That said, there are
    sha1-equivalent URLs if we'd prefer to keep them.
  • The URLs have file extensions, so don't need a separate type
    attribute

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: illicitonion
To complete the pull request process, please assign smukherj1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @smukherj1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes label Feb 11, 2021
@github-actions
Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Aug 11, 2021
@illicitonion
Switch to non-api fetch URLs
107a366 
This is a no-op change.

These URLs have a few advantages:
* GitHub is less aggressive at rate-limiting these URLs, and these URLs
  are easier to set up pass-through proxies for in an enterprise
  setting.
* The URLs self-document which tag is being fetched, rather than
  requiring separate comments to track tags (but the sha256 ensures
  re-pointed tags will still halt builds). That said, there are
  sha1-equivalent URLs if we'd prefer to keep them.
* The URLs have file extensions, so don't need a separate `type`
  attribute
alexeagle
alexeagle approved these changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Avoiding rate-limiting sounds great

@alexeagle alexeagle merged commit a71881c into bazelbuild:master Aug 11, 2021
@illicitonion illicitonion deleted the non-api-urls branch August 12, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@DaveGay DaveGay Awaiting requested review from DaveGay

@eytankidron eytankidron Awaiting requested review from eytankidron

@smukherj1 smukherj1 Awaiting requested review from smukherj1 smukherj1 is a code owner

@gravypod gravypod Awaiting requested review from gravypod gravypod is a code owner

@pcj pcj Awaiting requested review from pcj pcj is a code owner

Assignees
No one assigned
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illicitonion @k8s-ci-robot @alexeagle