Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container_test synthetic image does not inherit tags from the macro #1729

Closed
pcj opened this issue Feb 8, 2021 · 2 comments · Fixed by #1730
Closed

container_test synthetic image does not inherit tags from the macro #1729

pcj opened this issue Feb 8, 2021 · 2 comments · Fixed by #1730

Comments

@pcj
Copy link
Member

pcj commented Feb 8, 2021

A container_test rule "foo_test" will generate another target "foo_test.image" but currently tags like "tags = ['requires-cgo'] are not propagated to that image.

Screen Shot 2021-02-08 at 12 31 58 PM
pcj added a commit to pcj/rules_docker that referenced this issue Feb 8, 2021
@pcj
Propagate tags to the container image test bundle
a0a3cf5 
Fixes bazelbuild#1729
@pcj pcj mentioned this issue Feb 8, 2021
Merged
@aw185176
Copy link

"manual" is the one that is currently biting me

@pcj
Copy link
Member Author

pcj commented Mar 11, 2021

@alexeagle ping

@pcj pcj closed this as completed in #1730 Mar 12, 2021
pcj added a commit that referenced this issue Mar 12, 2021
@pcj
Propagate tags to the container image test bundle (#1730)
2a208c1 
Fixes #1729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate tags to the container image test bundle pcj/rules_docker
2 participants
@pcj @aw185176