Support bazelisk #346
Support bazelisk #346
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
zoidyzoidzoid
force-pushed
the
master
branch
from
e8853d5 to
0fed402
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Thanks for the quick review @achew22 , those are great points. Updated. |
| // /DIR/node_modules/@bazel/ibazel/bin/darwin_amd64/ibazel | ||
| // We can find bazelisk in | ||
| // /DIR/node_modules/@bazel/bazelisk/bazelizk-darwin_amd64 | ||
| func bazeliskNpmPath(ibazelBinPath string) (string, error) { |
There was a problem hiding this comment.
Could I have you add a test for this? It doesn't depend on any system calls or anything so a table driven test would be sufficient.
There was a problem hiding this comment.
Sorry, added these earlier but couldn't figure out why I was getting a segfault, but fixed now.
Fortunately they caught me missing the .exe extension for Windows. I'm not 100% comfortable with how I'm doing the platform detection though.
* 'master' of https://github.com/bazelbuild/bazel-watcher: Fix a lingering TODO (bazelbuild#362) Update dependency com_github_bazelbuild_rules_go to v0.22.1 (bazelbuild#354) Stamp can be passed without a value (bazelbuild#361) Update module golang/protobuf to v1.3.5 (bazelbuild#359) Update module fsnotify/fsnotify to v1.4.9 (bazelbuild#357) Generating CHANGELOG.md for release v0.12.3 Fix stamping regression caused by latest rules_go (bazelbuild#360) Update module golang/protobuf to v1.3.4 (bazelbuild#355) Update dependency io_bazel_rules_go to v0.22.1 (bazelbuild#335) Enable run_output by default (bazelbuild#349) Update module bazelbuild/rules_go to v0.22.1 (bazelbuild#336) Generating CHANGELOG.md for release v0.12.2 Release to the correct repo Generating CHANGELOG.md for release v0.12.0 Support bazelisk (bazelbuild#346) Generating CHANGELOG.md for release v0.11.2 Adds passthrough for "--compilation_mode" and "-c" (bazelbuild#348)
Closes #339
TODO: