Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the output runner #195

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Fix the output runner #195

merged 1 commit into from
Dec 6, 2018

Conversation

borkaehw
Copy link
Contributor

@borkaehw borkaehw commented Dec 5, 2018

The problem is introduced by 'Uncross stdout and stderr buffers' add8041. Since we switched stdoutBuffer and stderrBuffer, output_runner is not reading the correct output log.

@borkaehw
Fix the output runner
89a6d50 
The problem is introduced by 'Uncross stdout and stderr buffers'
@achew22
Copy link
Member

achew22 commented Dec 6, 2018

Thanks for the investigation and the fix!

@achew22 achew22 merged commit e539f73 into bazelbuild:master Dec 6, 2018
@borkaehw borkaehw deleted the fix-output-runner branch December 10, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borkaehw @achew22 @googlebot