Switch to python for workplace_status script #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
meteorcloudy
reviewed
Nov 5, 2018
| @@ -1,4 +1,4 @@ | |||
| build --workspace_status_command=tools/workplace_status.sh | |||
| build --workspace_status_command=tools/workplace_status.py | |||
There was a problem hiding this comment.
It's better to use build --workspace_status_command="python tools/workplace_status.py" because .py is not an executable extension on Windows by default.
There was a problem hiding this comment.
Could I have you add a section to the Bazel docs on windows compatibility for this? This seems like a thing that is worth documenting. Do you know if those are open sourced yet?
There was a problem hiding this comment.
Hmm, I'm also having the same concern as you do, that doing this will add python as a dependency for the project, but I couldn't think of a better solution yet. I prefer to discuss with my teammate (who's on vacation) first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.