Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update desugar_jdk_libs #19159

Closed
wants to merge 2 commits into from
Closed

Update desugar_jdk_libs #19159

wants to merge 2 commits into from

Conversation

katre
Copy link
Member

@katre katre commented Aug 3, 2023 •
edited
Loading

Needs to be split for submit to third_party and non-third_party.

Part of #19132.

@katre katre changed the title [WIP] Update desugar_jdk_libs Update desugar_jdk_libs Aug 3, 2023
@katre katre requested a review from meteorcloudy August 3, 2023 17:24
@katre katre marked this pull request as ready for review August 3, 2023 17:24
katre added 2 commits August 3, 2023 13:24
@katre
Add an in-place patch to update desugar_jdk_libs to remove use of
6d98694 
genrule.exec_tools.

Part of bazelbuild#19132.

This is preferable because of the large divergence in desugar_jdk_libs
between 5847d6a06302136d95a14b4cbd4b55a9c9f1436e and HEAD as of
2023-08-03.
@katre
Use the patch to update desugar_jdk_libs.
5a65740 
Part of bazelbuild#19132.
@katre katre force-pushed the update-desugar-2 branch from fd6d964 to 5a65740 Compare August 3, 2023 17:24
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Aug 3, 2023
@katre katre mentioned this pull request Aug 3, 2023
Closed
meteorcloudy
meteorcloudy approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 4, 2023
@meteorcloudy
Copy link
Member

You don't have to split this PR, we now check in part most of third_party in google3, only a few dirs are excluded.

The gTech team can help import this.

@meteorcloudy
Copy link
Member

But it would be nice if we could upstream the patch.

@meteorcloudy
Copy link
Member

Looks like it's already upstreamed at google/desugar_jdk_libs@4d60483, can we just use a newer commit then?

@copybara-service copybara-service bot closed this in 6a313f1 Aug 4, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 4, 2023
@katre katre deleted the update-desugar-2 branch August 4, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katre @meteorcloudy