Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export constraints.bzl file from @local_config_platform so it can be used in downstream bzl_library targets #16665

Closed
wants to merge 1 commit into from
Closed

fix: export constraints.bzl file from @local_config_platform so it can be used in downstream bzl_library targets #16665

wants to merge 1 commit into from

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Nov 4, 2022 •
edited
Loading

Downstream rule sets may depend on @local_config_platform//:constraints.bzl but when they do there is no way easy way to make that load statement compatible with bzl_library. This change makes it possible to use bzl_library on starlark code that loads from @local_config_platform//:constraints.bzl.

For example,

bzl_library(
    name = "local_config_platform_constraints",
    srcs = ["@local_config_platform//:constraints.bzl"],
)

bzl_library(
    name = "platform_utils",
    srcs = ["//lib/private:platform_utils.bzl"],
    deps = [":local_config_platform_constraints"],
)

@gregmagolan gregmagolan mentioned this pull request Nov 4, 2022
Merged
@gregmagolan gregmagolan marked this pull request as ready for review November 4, 2022 22:01
@gregmagolan
Copy link
Contributor Author

@katre Can you please take a look?

@sgowroji sgowroji added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Nov 7, 2022
@katre katre self-requested a review November 7, 2022 14:14
@katre katre added type: feature request and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 7, 2022
katre
katre approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@katre katre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@katre katre added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 7, 2022
@copybara-service copybara-service bot closed this in 4959d34 Nov 8, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 8, 2022
@fmeum
Copy link
Collaborator

fmeum commented Nov 8, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 8, 2022
@meteorcloudy
Copy link
Member

@bazel-io fork 6.0.0

@bazel-io bazel-io mentioned this pull request Nov 8, 2022
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 8, 2022
@ShreeM01 ShreeM01 mentioned this pull request Nov 8, 2022
Merged
ShreeM01 added a commit that referenced this pull request Nov 8, 2022
@ShreeM01 @gregmagolan
fix: export constraints.bzl file from @local_config_platform so it ca…
e9a931f 
…n be used in downstream bzl_library targets (#16698)

Downstream rule sets may depend on `@local_config_platform//:constraints.bzl` but when they do there is no way easy way to make that load statement compatible with `bzl_library`. This change makes it possible to use `bzl_library` on starlark code that loads from `@local_config_platform//:constraints.bzl`.

For example,

```
bzl_library(
    name = "local_config_platform_constraints",
    srcs = ["@local_config_platform//:constraints.bzl"],
)

bzl_library(
    name = "platform_utils",
    srcs = ["//lib/private:platform_utils.bzl"],
    deps = [":local_config_platform_constraints"],
)
```

Closes #16665.

PiperOrigin-RevId: 486957479
Change-Id: I328b7a3722aea95b3151ed88f23c277ed4154202

Co-authored-by: Greg Magolan <gmagolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katre katre katre approved these changes

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gregmagolan @fmeum @meteorcloudy @katre @bazel-io @sgowroji