feat: add StampSettingsInfo and STAMP_ATTRS #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
requested review from
alexeagle,
jbedard,
mattem and
soldair
as code owners
gregmagolan
force-pushed
the
npm_package_bin_stamp_env_vars
branch
from
dac7e94 to
b5234e2
Compare
gregmagolan
changed the title
|
Is it possible to add 'stamp' attr to nodejs_binary and nodejs_test too? |
gregmagolan
force-pushed
the
npm_package_bin_stamp_env_vars
branch
from
b5234e2 to
dc7b5ad
Compare
Definitely. @alexeagle or I will add that as a follow-up to this. |
alexeagle
reviewed
Dec 22, 2021
gregmagolan
force-pushed
the
npm_package_bin_stamp_env_vars
branch
2 times, most recently
from
781f819 to
245a8e8
Compare
gregmagolan
force-pushed
the
npm_package_bin_stamp_env_vars
branch
from
245a8e8 to
2b1288f
Compare
Is there an issue tracking this? I would currently use it to stamp a cypress e2e testing API key into the environment variables for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for stamp env vars
BAZEL_VERSION_FILEandBAZEL_INFO_FILEtorun_nodeif"stamp": STAMP_ATTRis inctx.attrAdds
stampattr tonpm_package_binAdds
stampattr topkg_npm(replacingnode_context_info)Adds
stampattr topkg_web(replacingnode_context_info)Adds
stampattr toesbuild(replacingnode_context_info)Adds
stampattr torollup_bundle(replacingnode_context_info)Removes old NodeContextData and NODE_CONTEXTS_ATTRS from
//internal/node/context.bzlin favor of StampSettingInfo and STAMP_ATTR from//nodejs/private/providers:stamp_setting_info.bzl