s/erlcassa/erlcql/ #116
Merged
s/erlcassa/erlcql/ #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlcassa's thrift implementation clashes with casbench's. erlcassa is nominally used as a cql client but was set up using thrift (which casbench does already) it was clearly labelled as alpha, and remains untouched in 2 years. erlcql is a real cql client, under active development and does not clash with casbench
|
This is currently failing as erlcql not yet fully backward-compatible with erlang <= R15B03-1 EDIT: brainfart correction. Sentences need subjects to provide context. |
|
|
|
Build now passes with updated erlcql |
|
Any news on what's going on with this PR? |
|
Hi @sanmiguel - I had lost track of this driver but thanks for keeping up to date with it. Your changes look great, I'll merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erlcassa's thrift implementation clashes with casbench's.
erlcassa is nominally used as a cql client but was set up using thrift
(which casbench does already)
it was clearly labelled as alpha, and remains untouched in 2 years.
erlcql is a real cql client, under active development and does not clash
with casbench