Enable setting of content_type for the riakc_pb driver #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2013 18:50
…ple on how to create objects with plain text from file.
|
Christian, any chance you'd also be able to hunt down this PB client return, added recently IIRC? It makes testing difficult: I get this error about 0.3 seconds after basho_bench has finished its init phase. |
|
Any progress on the problem highlighted by @slfritchie above? I'm seeing this problem too. |
| Robj2 = riakc_obj:update_value(Robj, ValueGen()), | ||
| [M | _] = riakc_obj:get_metadatas(Robj), | ||
| Robj1 = riakc_obj:update_metadata(Robj, M), | ||
| Robj2 = riakc_obj:update_value(Robj, ValueGen(), State#state.content_type), |
There was a problem hiding this comment.
Christian, you probably mean to use Robj1 somehow? I'm assuming line 214 is where you want to use it.
|
I've got one review comment that needs to be addressed, but it's quick. Everything else looks good, feel free to merge when the fix & final test is done, thanks! |
slfritchie
added a commit
that referenced
this pull request
Dec 10, 2013
Enable setting of content_type for the riakc_pb driver
|
I'm assuming Christian doesn't mind the merge. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the content type of objects to be specified when inserting or updating values, making it possible to generate objects containing text data that Riak Search and Yokozuna can index for benchmarks.
An example configuration file,
./examples/riakc_pb_text.config, shows how this can be achieved based on a sample text file has also been provided (./examples/AroundTheWorldIn80Days.txt). This creates and updates objects with a random, continuous 1000 byte sequence from the text.