Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe to reply #672

Merged
merged 21 commits into from
Sep 15, 2020
Merged

Swipe to reply #672

merged 21 commits into from
Sep 15, 2020

Conversation

wiruzx
Copy link
Contributor

@wiruzx wiruzx commented Sep 14, 2020

This pull request adds ability to reply message with a swipe gesture

Create an object conforming to ReplyActionHandler and add it to ChatViewController

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #672 into master will increase coverage by 40.50%.
The diff coverage is 23.56%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #672       +/-   ##
===========================================
+ Coverage   17.96%   58.47%   +40.50%     
===========================================
  Files          97       98        +1     
  Lines        5032     5117       +85     
===========================================
+ Hits          904     2992     +2088     
+ Misses       4128     2125     -2003     
Impacted Files Coverage Δ
...BaseChatViewController+CellPanGestureHandler.swift 0.00% <0.00%> (ø)
.../Chat Items/BaseMessage/BaseMessageViewModel.swift 86.66% <0.00%> (+86.66%) ⬆️
...e/Chat Items/PhotoMessages/PhotoMessageModel.swift 54.54% <0.00%> (+54.54%) ⬆️
...rce/Chat Items/TextMessages/TextMessageModel.swift 55.55% <0.00%> (+55.55%) ⬆️
...eMessage/Views/BaseMessageCollectionViewCell.swift 56.90% <17.14%> (+56.90%) ⬆️
...ntroller/Collaborators/CellPanGestureHandler.swift 19.78% <19.78%> (ø)
...troller/Collaborators/ReplyFeedbackGenerator.swift 33.33% <33.33%> (ø)
...Source/ChatController/BaseChatViewController.swift 69.78% <47.05%> (-1.33%) ⬇️
...urce/Chat Items/BaseMessage/BaseMessageModel.swift 66.66% <66.66%> (+66.66%) ⬆️
.../Chat Items/BaseMessage/BaseMessagePresenter.swift 61.90% <100.00%> (+61.90%) ⬆️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update accbb60...e34670d. Read the comment docs.

}

public protocol ReplyIndicatorRevealerDelegate: AnyObject {
func didPassTreshold(at: IndexPath)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: tHreshold

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wiruzx
Copy link
Contributor Author

wiruzx commented Sep 15, 2020

@leonspok Could you please take a look at last 4 commits?

@wiruzx wiruzx merged commit eefb2e5 into master Sep 15, 2020
@wiruzx wiruzx deleted the swipe-to-reply branch September 15, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants