Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public access modifiers needed for a new input bar #551

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

MikhailGasanov
Copy link
Contributor

UIScreen.defaultKeyboardHeightForCurrentOrientation is public
InputContainerView.contentHeight and InputContainerView.contentView are public

…ontainerView.contentHeight and InputContainerView.contentView are public
@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #551 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #551   +/-   ##
=======================================
  Coverage   60.04%   60.04%           
=======================================
  Files          87       87           
  Lines        3939     3939           
=======================================
  Hits         2365     2365           
  Misses       1574     1574
Impacted Files Coverage Δ
...ttoAdditions/Source/Input/InputContainerView.swift 0% <ø> (ø) ⬆️
ChattoAdditions/Source/Common/ScreenMetric.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff8c5a...aac6763. Read the comment docs.

@MikhailGasanov MikhailGasanov merged commit 36f0f61 into master Feb 13, 2019
@AntonPalich AntonPalich deleted the access_modifiers_updated_for_input_bar branch February 13, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants