Current coverage is 62.33%

Merging #55 into dev will increase coverage by +0.30% as of d0ab66e

@@              dev     #55   diff @@
=====================================
  Files          57      57       
  Stmts        2824    2857    +33
  Branches        0       0       
  Methods         0       0       
=====================================
+ Hit          1752    1781    +29
  Partial         0       0       
- Missed       1072    1076     +4

Review entire Coverage Diff as of d0ab66e

Powered by Codecov. Updated on successful CI builds.

@zwang This is amazing! So exciting to see such a nice contribution from the community 😍. Hopefully you can address some of my comments. Thank you very much again!

@diegosanchezr thanks for the review and notes. I will revisit them this weekend and update the PR then. Thanks again :)

@diegosanchezr thanks a lot for the review and feedback again. It all makes sense. I am hesitate to change based on the last note as I commented above. So I will leave it there for now and get more familiar with the code first.

Other than the last note, I should have resolved all issues in all the other notes. And also I add two new small features: 1. Allow user to subclass the basestyle to specify VerticalAlignment for the avatar, like Top or Center, by default it is Bottom. 2. Allow user to subclass the basestyle to change the default BaseMessageCollectionViewCellLayoutConstants. These two features are both needed for my project. And I think they should be helpful to others as well. It remains simple and yet allow others to extend to customize the base collection view cell.

Thanks again for you help. Have a good one! Cheers! :)

PS: I will resolve other self.dynamicType issues in the library later once this is merged.

@zwang thank you very much again! merging!

@diegosanchezr Thank you. :)

@zwang Hi and thanks for your effort in this feature. I have a couple questions. I downloaded the dev branch and the Avatars seems to be only next to text typed messages but not image typed ones. Is this a design choice or are you still working on adding them to all message types?

Since there is a senderId in MessageModelProtocol, can we display different avatars according to the senderId's? Does that mean that the feature you are working on is not just Avatar support and also covers group chat support as @diegosanchezr pointed out in the issue I have opened named: "Group Chat Support"? If thats the case, then images will need the avatars to be next to them.

I really believe Group chat is a vital part of chat and it should be present in this beautiful Library:)

Last question will be about the avatar views. Are they just UIImage's? or UIViews? the reason I am asking is if they are UIView's, It would be easy to display a UILabel beneath the avatars which is necessary for group chat. I realize there is not much horizontal space for the names but at least initials can be displayed or we can use small fonts just to inform the user. I don't think just the avatars are enough, since it is a big possibility that people can have same avatars or no avatars set at all.

Thanks to all of you who are keeping this Library alive:)

Hi @aytunch

First, the feature only supports adding avatar to messages. Not related to group chat. But should work in group chat too. It is just a matter of setting the avatar image for each message.

With this said, it allow you to put avatar image next to photo messages too. I just didn't do it in the demo app. You can checkout DemoTextMessageViewModel.swift line 49 and do the same thing for photo message in DemoPhotoMessageViewModel.swift just for a quick demo.

You definitely can display different avatar image according to senderId. What I did in the demo app is just an example, you can set the avatarImage value of MessageViewModelProtocol in any place as long as it make sense to you. For myself, I did in each message presenter.

Regarding the sender name under avatar, I think you can do the same extension as I did for avatar view. I would not recommend to have name bound together with avatar view. They can stay together, but they should not be bound together. So the avatar view is just an UIImageView holding images. An good idea might be to display the name right above the bubble.

Hope my answer helps. :)