Fixed issue with wrong input accessory view position on iOS 12 #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 2, 2018 15:05
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
==========================================
- Coverage 64.7% 63.06% -1.65%
==========================================
Files 76 77 +1
Lines 3924 4034 +110
==========================================
+ Hits 2539 2544 +5
- Misses 1385 1490 +105
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #514
A new way of managing keyboard input views was introduced.
Previously,
ChatInputItem.inputViewwas assigned toUIResponder.inputViewdirectly with.flexibleHeightand.flexibleWidthautoresizing masks. This allowed UIKit to manage input views sizes but this approach lead to #514 issue on iOS 12.Now, we're using
UIInputViewas a container and manage its size manually by changingUIInputView.allowSelfSizingproperty totrue. That means, that we need to provide input view size every time we want to present it and we can't rely on UIKit sizing anymore. If keyboard wasn't presented in a specific chat and we didn't cache keyboard size then we use hardcoded size based on a device and current orientation.Also this change required to increase deployment target to
9.0