Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash that happens under some conditions #405

Merged
merged 1 commit into from
Nov 23, 2017

Conversation

AntonPalich
Copy link
Contributor

Crash is reproducible in swift_runtime_bug_example branch. It's caused by a compatibility issue between Swift 3 and Swift 4 modules.

@codecov-io
Copy link

codecov-io commented Nov 23, 2017

Codecov Report

Merging #405 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   63.77%   63.82%   +0.05%     
==========================================
  Files          63       63              
  Lines        3589     3594       +5     
==========================================
+ Hits         2289     2294       +5     
  Misses       1300     1300
Impacted Files Coverage Δ
...ws/BaseMessageCollectionViewCellDefaultStyle.swift 87.14% <100%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4156b0...5ee18ea. Read the comment docs.

@AntonPalich AntonPalich merged commit 74cfc38 into master Nov 23, 2017
@AntonPalich AntonPalich deleted the swift4_swift3.2_crash branch November 23, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants