Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change camera cell UI after setting new appearance. #404

Merged
merged 2 commits into from
Nov 22, 2017
Merged

Change camera cell UI after setting new appearance. #404

merged 2 commits into from
Nov 22, 2017

Conversation

Wisors
Copy link
Contributor

@Wisors Wisors commented Nov 22, 2017

LiveCameraCell is always using camera icon from default LiveCameraCellAppearance instance during the first appearance on the screen and change it only after this cell was reused. The fix is to update UI after new appearance was set.

@codecov-io
Copy link

codecov-io commented Nov 22, 2017

Codecov Report

Merging #404 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
- Coverage   63.93%   63.87%   -0.06%     
==========================================
  Files          63       63              
  Lines        3585     3588       +3     
==========================================
  Hits         2292     2292              
- Misses       1293     1296       +3
Impacted Files Coverage Δ
...Additions/Source/Input/Photos/LiveCameraCell.swift 86.2% <100%> (+0.75%) ⬆️
...Chat Items/TextMessages/Views/TextBubbleView.swift 67.03% <0%> (-1.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b77e25...a2645a2. Read the comment docs.

@Wisors Wisors changed the base branch from master to swift-3 November 22, 2017 18:11
@AntonPalich AntonPalich merged commit 9fffc7d into badoo:swift-3 Nov 22, 2017
@Wisors Wisors mentioned this pull request Dec 7, 2017
@Wisors Wisors deleted the fix_custom_camera_icon_swift3 branch January 10, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants