cli: experimental support for using embedded-postgres as dev DB #28318
+193
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Rugvip
requested review from
benjdlambert and
vinzscam
and removed request for
a team
|
Gonna try moving this one over to |
|
Tried Leaning back towards this most likely being the better option unless we can find a way to re-use the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Does what is says on the tin. This is on top of #28308 because it needs support for module-only packages, and is a parallel to #28315.
Some rough benchmarking shows that this slows down the initial startup time of the backend somewhat, while restarts are about the same speed for a small DB, but noticeably faster with a large DB. Of course performance isn't really the main concern with moving in this direction as long as it's good enough. The biggest upside would be to eventually be able to drop the need for supporting SQLite and thereby simplifying DB code a lot.
✔️ Checklist
Signed-off-byline in the message. (more info)