Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(notifications): improve router tests #28050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(notifications): improve router tests #28050

wants to merge 1 commit into from
+463 −27

Conversation

drodil
Copy link
Contributor

@drodil drodil commented Dec 9, 2024

Hey, I just made a Pull Request!

improve the existing router tests for notifications to handle different endpoints.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@drodil drodil requested review from a team as code owners December 9, 2024 10:56
@drodil drodil requested a review from Rugvip December 9, 2024 10:56
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Dec 9, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-notifications-backend plugins/notifications-backend patch v0.5.0-next.2

@drodil drodil force-pushed the notification_tests branch from 65391cf to b6a1dd2 Compare December 9, 2024 10:56
@drodil
Copy link
Contributor Author

drodil commented Dec 9, 2024

@mareklibra still missing few endpoints and parameters but this greatly improves the coverage

@drodil drodil mentioned this pull request Dec 10, 2024
Merged
5 tasks
Rugvip
Rugvip approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

Just some optional things

plugins/notifications-backend/src/service/router.test.ts Outdated Show resolved Hide resolved
plugins/notifications-backend/src/service/router.test.ts Outdated Show resolved Hide resolved
plugins/notifications-backend/src/service/router.ts Outdated Show resolved Hide resolved
plugins/notifications-backend/src/service/router.ts Outdated Show resolved Hide resolved
@drodil drodil force-pushed the notification_tests branch from b6a1dd2 to 70919c3 Compare December 13, 2024 11:17
@drodil
test(notifications): improve router tests
0564028 
improve the existing router tests for notifications to handle different
endpoints.

Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
@drodil drodil force-pushed the notification_tests branch from 70919c3 to 0564028 Compare December 13, 2024 11:48
@drodil
Copy link
Contributor Author

drodil commented Dec 13, 2024

@Rugvip rebased and fixed the comments!

Rugvip
Rugvip approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 :shipit:

@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Dec 27, 2024
@freben
Copy link
Member

freben commented Dec 27, 2024

Ach, there seems to be a conflict.

@github-actions github-actions bot removed the stale label Dec 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jan 10, 2025
@drodil
Copy link
Contributor Author

drodil commented Jan 11, 2025

Not stale

@github-actions github-actions bot removed the stale label Jan 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jan 25, 2025
@drodil
Copy link
Contributor Author

drodil commented Jan 25, 2025

Not stale

@github-actions github-actions bot removed the stale label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rugvip Rugvip Rugvip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drodil @freben @Rugvip