Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch release of #27291, #27273, #27255, #27308 #27317

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Patch release of #27291, #27273, #27255, #27308 #27317

merged 5 commits into from
Oct 23, 2024

Conversation

benjdlambert
Copy link
Member

This release fixes the following issues:

  • Scaffolder form state not being tracked correctly, this reverts some of the liveOmit and omitExtraData functionality that was recently release. We're gonna look at shipping this a better way soon 🤞
  • Fix events.useEventBus by propagating config to DefaultEventsService
  • Small fix for sha tree treading for repo test command

@benjdlambert
Patch from PR #27291
a2acc0d 
Signed-off-by: blam <ben@blam.sh>
@benjdlambert
Patch from PR #27273
e2f94f7 
Signed-off-by: blam <ben@blam.sh>
@benjdlambert
Patch from PR #27255
7bd2fe9 
Signed-off-by: blam <ben@blam.sh>
@benjdlambert
Patch from PR #27308
c5276b6 
Signed-off-by: blam <ben@blam.sh>
@benjdlambert benjdlambert requested review from a team and pjungermann as code owners October 23, 2024 10:14
@github-actions github-actions bot added area:catalog Related to the Catalog Project Area area:techdocs Related to the TechDocs Project Area search Things related to Search area:scaffolder Everything and all things related to the scaffolder project area area:events Related to the Events Project Area area:search labels Oct 23, 2024
Rugvip
Rugvip reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a lot of unrelated patch bumps, not sure where they're from but I think it's best if we trim those out

@benjdlambert benjdlambert force-pushed the patch-release-pr-27291-27273-27255-27308 branch from 35b773c to 720169e Compare October 23, 2024 11:24
@github-actions github-actions bot removed area:catalog Related to the Catalog Project Area area:techdocs Related to the TechDocs Project Area search Things related to Search area:search labels Oct 23, 2024
@benjdlambert benjdlambert force-pushed the patch-release-pr-27291-27273-27255-27308 branch 2 times, most recently from 42618b0 to dc65431 Compare October 23, 2024 11:51
@benjdlambert
Generate Release
adf13bb 
Signed-off-by: blam <ben@blam.sh>
@benjdlambert benjdlambert force-pushed the patch-release-pr-27291-27273-27255-27308 branch from dc65431 to adf13bb Compare October 23, 2024 11:53
@benjdlambert benjdlambert mentioned this pull request Oct 23, 2024
Closed
2 tasks
@benjdlambert benjdlambert merged commit 1d032d0 into patch/v1.32.0 Oct 23, 2024
17 checks passed
@benjdlambert benjdlambert deleted the patch-release-pr-27291-27273-27255-27308 branch October 23, 2024 13:55
@kmikko kmikko mentioned this pull request Nov 4, 2024
Closed
@kmikko kmikko mentioned this pull request Nov 27, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rugvip Rugvip Rugvip left review comments

@freben freben freben approved these changes

@pjungermann pjungermann Awaiting requested review from pjungermann

@camilaibs camilaibs Awaiting requested review from camilaibs camilaibs is a code owner automatically assigned from backstage/reviewers

@acierto acierto Awaiting requested review from acierto acierto is a code owner automatically assigned from backstage/scaffolder-maintainers

Assignees
No one assigned
Labels
area:events Related to the Events Project Area area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjdlambert @freben @Rugvip