Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for importing ESM packages into node modules #19855

Closed
wants to merge 1 commit into from

Conversation

davidscodex
Copy link

@davidscodex davidscodex commented Sep 8, 2023

Hey, I just made a Pull Request!

Renamed esm.js files to mjs. This will allow node modules to import the packages.

Fixes issue #19854

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: David Sullivan <david.sullivan@usecodex.com>
@davidscodex davidscodex requested review from a team as code owners September 8, 2023 18:59
@davidscodex davidscodex requested review from freben and tudi2d September 8, 2023 18:59
@backstage-goalie
Copy link
Contributor

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

  • .changeset/cold-coins-speak.md: @backstage/app-defaults, @backstage/catalog-client, @backstage/catalog-model, @backstage/config, @backstage/core-app-api, @backstage/core-components, @backstage/core-plugin-api, @backstage/dev-utils, @backstage/errors, @backstage/frontend-app-api, @backstage/frontend-plugin-api, @backstage/integration, @backstage/integration-react, @backstage/release-manifests, @backstage/test-utils, @backstage/theme, @backstage/types, @backstage/version-bridge

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/cli packages/cli patch v0.22.13-next.2

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Uffizzi Ephemeral Environment deployment-35545

☁️ https://app.uffizzi.com/github.com/backstage/backstage/pull/19855

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@freben
Copy link
Member

freben commented Sep 12, 2023

Your changeset lists a lot of unchanged packages, as you'll see - and the end to end tests don't like this.

@davidscodex
Copy link
Author

The change impacts how those packages are generated. What is the best method to ensure those packages are updated with this change?

@freben
Copy link
Member

freben commented Sep 15, 2023

Hm in that case, should the changeset contain every single ESM enabled package, such as all plugins/ folder frontend, react, and common packages?

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants