Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/entity dependencies card enhancements #18504

Merged
merged 8 commits into from
Jul 10, 2023
Merged

Feature/entity dependencies card enhancements #18504

merged 8 commits into from
Jul 10, 2023

Conversation

Abhay-soni-developer
Copy link
Contributor

I have extended the EntityHasSubcomponentsCard, EntityDependsOnResourcesCard and EntityDependsOnResourcesCard and EntityTable to supports tableOptions.

i have extended these components in such a way that it does not effect the current implementation just extend it capabilities to support tableOptions

This PR is the implementation for this #18503

@Abhay-soni-developer
added additional props in entity dependecies cards to manage table op…
71573c9 
…tions

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
Merge branch 'master' into feature/entity-dependencies-card-enhancements
cbd18fc 
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
DepenedsOnResourcesCard, EntityHasSubcomponentsCard
ecacbce 
now we can pass tableOptions props through them

Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer Abhay-soni-developer requested review from a team as code owners June 30, 2023 07:35
@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label Jun 30, 2023
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Jun 30, 2023 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-react plugins/catalog-react minor v1.7.1-next.1
@backstage/plugin-catalog plugins/catalog minor v1.11.3-next.1

@Abhay-soni-developer Abhay-soni-developer mentioned this pull request Jun 30, 2023
Closed
2 tasks
@Abhay-soni-developer
Copy link
Contributor Author

@Rugvip @benjaminr @Edje-C @awanlin

@NishkarshRaj
Copy link
Contributor

This is pretty helpful.

As we scale Backstage adoption, we don't want to scroll down a lot. So from a UX perspective - Pagination and Filtering is a bliss.

@NishkarshRaj
Copy link
Contributor

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @backstage/plugin-catalog-react
  • @backstage/plugin-catalog

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-react plugins/catalog-react none v1.7.1-next.0
@backstage/plugin-catalog plugins/catalog none v1.11.3-next.0

@Abhay-soni-developer ☝️

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023 •
edited
Loading

Uffizzi Preview deployment-29816 was deleted.

@Abhay-soni-developer
docs modified
6bd5541 
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@benjdlambert
Copy link
Member

@Abhay-soni-developer this will need some changesets 🙏

@Abhay-soni-developer
changeset added
eae0352 
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
changeset modified
0d28d2b 
Signed-off-by: Abhay-soni-developer <abhaysoni.developer@gmail.com>
benjdlambert
benjdlambert requested changes Jul 5, 2023
View reviewed changes
.changeset/popular-icons-doubt.md Outdated Show resolved Hide resolved
@Abhay-soni-developer @benjdlambert
Update .changeset/popular-icons-doubt.md
540b1c5 
feedback integrated

Co-authored-by: Ben Lambert <ben@blam.sh>
Signed-off-by: Abhay Soni <abhaysoni.developer@gmail.com>
@Abhay-soni-developer
Copy link
Contributor Author

@benjdlambert the requested changes have been done. are we ready to merge this

@benjdlambert benjdlambert enabled auto-merge July 6, 2023 08:51
@Abhay-soni-developer
Copy link
Contributor Author

@benjdlambert i just merged the feedbacks after that pipeline is failing , can you help me resolve this
as i can not find the reason of failure

@benjdlambert benjdlambert disabled auto-merge July 10, 2023 11:47
@benjdlambert benjdlambert merged commit 91d791f into backstage:master Jul 10, 2023
@benjdlambert
Copy link
Member

benjdlambert commented Jul 10, 2023 •
edited
Loading

The e2e's are failing for a seperate reason - i've just merged this and we will fix e2es in a later PR when upstream types are fixed.

@github-actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.16.0 release, scheduled for Tue, 18 Jul 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjdlambert benjdlambert benjdlambert approved these changes

@Edje-C Edje-C Awaiting requested review from Edje-C Edje-C is a code owner automatically assigned from backstage/catalog-maintainers

Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abhay-soni-developer @NishkarshRaj @benjdlambert