Respect BABEL_8_BREAKING option in babel-types fields test
#17000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58407 |
JLHwung
force-pushed
the
respect-babel-8-breaking-option
branch
from
134849c to
c386045
Compare
up to 10% faster because the Object.keys(missingFields).length check is replaced with a simple null check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is extracted from #16979: The fields test now respects the
BABEL_8_BREAKINGoption and will test the AST nodes that is different between Babel 7 and Babel 8.Previously we ignored the Babel 8 AST changes and had to filled in all the AST changes to the test file.