perf: Reduce the use of temporary objects #16959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
commented
Nov 12, 2024
Comment on lines
866
to
875
| printJoin( | ||
| nodes: Array<t.Node> | undefined | null, | ||
| opts: PrintJoinOptions = {}, | ||
| statement?: boolean, | ||
| indent?: boolean, | ||
| separator?: PrintJoinOptions["separator"], | ||
| printTrailingSeparator?: boolean, | ||
| addNewlines?: PrintJoinOptions["addNewlines"], | ||
| iterator?: PrintJoinOptions["iterator"], | ||
| trailingCommentsLineOffset?: number, | ||
| ) { |
There was a problem hiding this comment.
Their order is similar to the frequency of use.
There was a problem hiding this comment.
There are quite a few boolean options here, maybe we can pack them into bit flags.
There was a problem hiding this comment.
I was originally working on bit flags, but then realized the code needed was pretty much the same either way.
I'll switch it over to bit flags and see if that makes it a bit cleaner. :)
There was a problem hiding this comment.
Seems a bit difficult since indent===null would make sense.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58329 |
JLHwung
approved these changes
Nov 12, 2024
liuxingbaoyu
added
pkg: generator
PR: Performance 🏃♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2#16958 (review)
main
PR