Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CI with Node v23.1.0 #16932

Merged
merged 3 commits into from
Oct 25, 2024
Merged

fix: CI with Node v23.1.0 #16932

merged 3 commits into from
Oct 25, 2024

Conversation

liuxingbaoyu
Copy link
Member

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Oct 25, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58246

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Oct 25, 2024 •
edited
Loading

Did you mean 22.10.0? Or 23.1.0?

@liuxingbaoyu liuxingbaoyu changed the title fix: CI with Node v22.1.0 fix: CI with Node v23.1.0 Oct 25, 2024
@liuxingbaoyu
Copy link
Member Author

Oops, I meant v23.1.0.

@liuxingbaoyu @nicolo-ribaudo
Update packages/babel-core/test/helpers/esm.js
6acffcd 
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
@nicolo-ribaudo nicolo-ribaudo merged commit 8b5b6bf into babel:main Oct 25, 2024
54 checks passed
JLHwung
JLHwung reviewed Oct 25, 2024
View reviewed changes
packages/babel-core/test/helpers/esm.js
...process.env,
NODE_OPTIONS:
parseInt(process.versions.node) >= 23
? "--disable-warning=ExperimentalWarning"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does node 23.1 updated the error message? We already removed the experimental warning from stderr.

Plus if we provide other NODE_OPTIONS, this will replaced the provided options and with --disable-warning only.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see the failure at https://github.com/babel/babel/actions/runs/11509402711/job/32039492498 (commit: dd4ad48)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so node.js 23.1 updated the experimental warning: now they will print which file imports which module:

ExperimentalWarning: CommonJS module /home/runner/work/babel/babel/packages/babel-core/lib/config/files/module-types.js is loading ES Module /home/runner/work/babel/babel/packages/babel-core/test/fixtures/async/preset-mjs-native/preset.mjs using require().
    Support for loading ES Module in require() is an experimental feature and might change at any time
    (Use `node --trace-warnings ...` to show where the warning was created)

Could have updated the experimental warning regex so we will not accidentally miss unwanted experimental warnings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open another PR? 🙏

JLHwung added a commit to JLHwung/babel that referenced this pull request Oct 25, 2024
@JLHwung
Revert "fix: CI with Node v23.1.0 (babel#16932)"
7847014 
This reverts commit 8b5b6bf.
@JLHwung JLHwung mentioned this pull request Oct 25, 2024
Merged
nicolo-ribaudo pushed a commit that referenced this pull request Oct 25, 2024
@JLHwung
Update node 23.1 experimental warning (#16934)
61de718 
* Revert "fix: CI with Node v23.1.0 (#16932)"

This reverts commit 8b5b6bf.

* update known experimental warning regex
DylanPiercey pushed a commit to DylanPiercey/babel that referenced this pull request Oct 25, 2024
@JLHwung @DylanPiercey
Update node 23.1 experimental warning (babel#16934)
2c30427 
* Revert "fix: CI with Node v23.1.0 (babel#16932)"

This reverts commit 8b5b6bf.

* update known experimental warning regex
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 25, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@JLHwung JLHwung JLHwung left review comments

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liuxingbaoyu @babel-bot @nicolo-ribaudo @JLHwung