Always enable parsing of Flow enums #16841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: New Feature 🚀
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58199 |
nicolo-ribaudo
force-pushed
the
flow-enums
branch
from
441e50c to
d29cf87
Compare
JLHwung
approved these changes
Sep 16, 2024
|
I'm concerned that TS's |
|
I would do it just for this, since this is purely a new feature. That other one also changes behavior of existing code. |
liuxingbaoyu
approved these changes
Sep 17, 2024
nicolo-ribaudo
added
PR: Ready to be Merged
|
No docs needed, as the |
nicolo-ribaudo
force-pushed
the
flow-enums
branch
from
dfc541a to
46d8248
Compare
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2#16792 is adding an error in Babel 8 when specifying the option so that people notice that they can remove it. However, we can already ease the migration by enabling it by default in Babel 7.