Ignore devDependencies when generating tsconfig.json
#16659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
changed the title
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57509 |
nicolo-ribaudo
force-pushed
the
feat-7.25.0/remove-cycles
branch
2 times, most recently
from
bcac3c8 to
62b12b0
Compare
nicolo-ribaudo
force-pushed
the
nice-tsconfig
branch
from
dc5c714 to
eec2ec7
Compare
nicolo-ribaudo
force-pushed
the
nice-tsconfig
branch
from
b652311 to
8040cb4
Compare
nicolo-ribaudo
changed the title
devDependencies when generating tsconfig.json
nicolo-ribaudo
added
PR: Internal (next major) 🏠
nicolo-ribaudo
commented
Jul 31, 2024
nicolo-ribaudo
force-pushed
the
nice-tsconfig
branch
from
8376104 to
927d2ea
Compare
liuxingbaoyu
approved these changes
Jul 31, 2024
| @@ -39,7 +55,7 @@ function getTsPkgs(subRoot) { | |||
| name === "@babel/compat-data" || | |||
| fs.existsSync(new URL(relative + "/src/index.ts", rootURL)); | |||
| if (!ret) { | |||
| console.log(`Skipping ${name} for tsconfig.json`); | |||
| // console.log(`Skipping ${name} for tsconfig.json`); | |||
There was a problem hiding this comment.
Yeah, it was just annoying whenever we have empty folders due to changing branch 😅
I left it commented out so that we can re-enable it if we have to debug the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2This PR lets us publish d.ts for Babel 8.
There is only one remaining cycle between our packages (@babel/core <> @babel/helper-module-transforms), which will go away in Babel 8 as we'll remove the dependency. This cycle doesn't affect types, so we can manually ignore it.
This PR also improves type checking time: it's now 29s for a full clean
make tscheckand 12s for a subsequentmake tscheckrun on my machine.