Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide legacy typings for TS < 4.1 #16638

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 12, 2024

Q                       A
Fixed Issues? Fixes #16637
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In #16570 we improved the typings for getBindingIdentifiers via Key Remapping in Mapped Types, which is a TypeScript 4.1 feature. Note that TypeScript 4.1 was released in November 2020 (almost 4 years ago).

As we already provide legacy typings for TS < 3.7, here we bump the legacy typing condition to TS < 4.1. Hopefully this should address the @babel/types type check errors on TS < 4.1.

@JLHwung JLHwung added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jul 12, 2024
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57334

@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 12, 2024

When I paste https://unpkg.com/@babel/types@7.24.8/lib/index-legacy.d.ts into TypeScript playground with TS 3.6.3, there are parser errors for

// Function implementation is missing or not immediately following the declaration.
export function booleanLiteralTypeAnnotation(value: boolean): BooleanLiteralTypeAnnotation;

Same errors with 3.7 or 4.0

I think we should add a test job for legacy typings.

@nicolo-ribaudo
Copy link
Member

I get no errors -- did you set the language to "TypeScrpt Declaration"?

@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 12, 2024

I get no errors -- did you set the language to "TypeScrpt Declaration"?

Indeed, thanks! Merging it as-is.

@JLHwung JLHwung merged commit de47960 into babel:main Jul 12, 2024
51 checks passed
@JLHwung JLHwung deleted the provide-legacy-typings-for-ts-lte-40 branch July 12, 2024 16:12
@SimenB
Copy link
Contributor

SimenB commented Jul 15, 2024

I think we should add a test job for legacy typings.

FWIW, Jest uses tstyche which has good support for type tests using different versions of TS. Dunno if you actually wanna test your types or just ensure they compile, tho

brandonb927 pushed a commit to brandonb927/brandonb-sites that referenced this pull request Jul 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@babel/core](https://babel.dev/docs/en/next/babel-core) ([source](https://github.com/babel/babel/tree/HEAD/packages/babel-core)) | dependencies | patch | [`7.24.7` -> `7.24.9`](https://renovatebot.com/diffs/npm/@babel%2fcore/7.24.7/7.24.9) |

---

### Release Notes

<details>
<summary>babel/babel (@&#8203;babel/core)</summary>

### [`v7.24.9`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7249-2024-07-15)

[Compare Source](babel/babel@v7.24.8...v7.24.9)

##### 🐛 Bug Fix

-   `babel-core`, `babel-standalone`
    -   [#&#8203;16639](babel/babel#16639) Avoid `require()` call in `@babel/standalone` bundle ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))
-   `babel-types`
    -   [#&#8203;16638](babel/babel#16638) fix: provide legacy typings for TS < 4.1 ([@&#8203;JLHwung](https://github.com/JLHwung))

##### 💅 Polish

-   `babel-generator`, `babel-plugin-transform-optional-chaining`
    -   [#&#8203;16617](babel/babel#16617) Avoid extra parens in TS `as`/`satisfies` ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))

##### 🏠 Internal

-   `babel-helper-module-transforms`
    -   [#&#8203;16629](babel/babel#16629) Lazy top-level initializations for module transforms ([@&#8203;guybedford](https://github.com/guybedford))

### [`v7.24.8`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7248-2024-07-11)

[Compare Source](babel/babel@v7.24.7...v7.24.8)

##### 👓 Spec Compliance

-   `babel-parser`
    -   [#&#8203;16567](babel/babel#16567) Do not use strict mode in TS `declare` ([@&#8203;liuxingbaoyu](https://github.com/liuxingbaoyu))

##### 🐛 Bug Fix

-   `babel-generator`
    -   [#&#8203;16630](babel/babel#16630) Correctly print parens around `in` in `for` heads ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))
    -   [#&#8203;16626](babel/babel#16626) Fix printing of comments in `await using` ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))
    -   [#&#8203;16591](babel/babel#16591) fix typescript code generation for yield expression inside type expre… ([@&#8203;SreeXD](https://github.com/SreeXD))
-   `babel-parser`
    -   [#&#8203;16613](babel/babel#16613) Disallow destructuring assignment in `using` declarations ([@&#8203;H0onnn](https://github.com/H0onnn))
    -   [#&#8203;16490](babel/babel#16490) fix: do not add `.value: undefined` to regexp literals ([@&#8203;liuxingbaoyu](https://github.com/liuxingbaoyu))
-   `babel-types`
    -   [#&#8203;16615](babel/babel#16615) Remove boolean props from `ObjectTypeInternalSlot` visitor keys ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))
-   `babel-plugin-transform-typescript`
    -   [#&#8203;16566](babel/babel#16566) fix: Correctly handle `export import x =` ([@&#8203;liuxingbaoyu](https://github.com/liuxingbaoyu))

##### 💅 Polish

-   `babel-generator`
    -   [#&#8203;16625](babel/babel#16625) Avoid unnecessary parens around `async` in `for await` ([@&#8203;nicolo-ribaudo](https://github.com/nicolo-ribaudo))
-   `babel-traverse`
    -   [#&#8203;16619](babel/babel#16619) Avoid checking `Scope.globals` multiple times ([@&#8203;liuxingbaoyu](https://github.com/liuxingbaoyu))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://git.brandonb.ca/brandon/personal-sites/pulls/2
Reviewed-by: brandon <brandon+gitea@brandonb.ca>
Co-authored-by: Renovate Bot <renovate-bot@brandonb.ca>
Co-committed-by: Renovate Bot <renovate-bot@brandonb.ca>
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @babel/types TypeScript error after v7.24.8 publication
5 participants