-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: provide legacy typings for TS < 4.1 #16638
fix: provide legacy typings for TS < 4.1 #16638
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57334 |
When I paste https://unpkg.com/@babel/types@7.24.8/lib/index-legacy.d.ts into TypeScript playground with TS 3.6.3, there are parser errors for // Function implementation is missing or not immediately following the declaration.
export function booleanLiteralTypeAnnotation(value: boolean): BooleanLiteralTypeAnnotation; Same errors with 3.7 or 4.0 I think we should add a test job for legacy typings. |
I get no errors -- did you set the language to "TypeScrpt Declaration"? |
Indeed, thanks! Merging it as-is. |
FWIW, Jest uses |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@babel/core](https://babel.dev/docs/en/next/babel-core) ([source](https://github.com/babel/babel/tree/HEAD/packages/babel-core)) | dependencies | patch | [`7.24.7` -> `7.24.9`](https://renovatebot.com/diffs/npm/@babel%2fcore/7.24.7/7.24.9) | --- ### Release Notes <details> <summary>babel/babel (@​babel/core)</summary> ### [`v7.24.9`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7249-2024-07-15) [Compare Source](babel/babel@v7.24.8...v7.24.9) ##### 🐛 Bug Fix - `babel-core`, `babel-standalone` - [#​16639](babel/babel#16639) Avoid `require()` call in `@babel/standalone` bundle ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-types` - [#​16638](babel/babel#16638) fix: provide legacy typings for TS < 4.1 ([@​JLHwung](https://github.com/JLHwung)) ##### 💅 Polish - `babel-generator`, `babel-plugin-transform-optional-chaining` - [#​16617](babel/babel#16617) Avoid extra parens in TS `as`/`satisfies` ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🏠 Internal - `babel-helper-module-transforms` - [#​16629](babel/babel#16629) Lazy top-level initializations for module transforms ([@​guybedford](https://github.com/guybedford)) ### [`v7.24.8`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7248-2024-07-11) [Compare Source](babel/babel@v7.24.7...v7.24.8) ##### 👓 Spec Compliance - `babel-parser` - [#​16567](babel/babel#16567) Do not use strict mode in TS `declare` ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 🐛 Bug Fix - `babel-generator` - [#​16630](babel/babel#16630) Correctly print parens around `in` in `for` heads ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#​16626](babel/babel#16626) Fix printing of comments in `await using` ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#​16591](babel/babel#16591) fix typescript code generation for yield expression inside type expre… ([@​SreeXD](https://github.com/SreeXD)) - `babel-parser` - [#​16613](babel/babel#16613) Disallow destructuring assignment in `using` declarations ([@​H0onnn](https://github.com/H0onnn)) - [#​16490](babel/babel#16490) fix: do not add `.value: undefined` to regexp literals ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-types` - [#​16615](babel/babel#16615) Remove boolean props from `ObjectTypeInternalSlot` visitor keys ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-plugin-transform-typescript` - [#​16566](babel/babel#16566) fix: Correctly handle `export import x =` ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 💅 Polish - `babel-generator` - [#​16625](babel/babel#16625) Avoid unnecessary parens around `async` in `for await` ([@​nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-traverse` - [#​16619](babel/babel#16619) Avoid checking `Scope.globals` multiple times ([@​liuxingbaoyu](https://github.com/liuxingbaoyu)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.brandonb.ca/brandon/personal-sites/pulls/2 Reviewed-by: brandon <brandon+gitea@brandonb.ca> Co-authored-by: Renovate Bot <renovate-bot@brandonb.ca> Co-committed-by: Renovate Bot <renovate-bot@brandonb.ca>
In #16570 we improved the typings for
getBindingIdentifiers
via Key Remapping in Mapped Types, which is a TypeScript 4.1 feature. Note that TypeScript 4.1 was released in November 2020 (almost 4 years ago).As we already provide legacy typings for TS < 3.7, here we bump the legacy typing condition to TS < 4.1. Hopefully this should address the @babel/types type check errors on TS < 4.1.