Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump commander to 6.2.0 #16509

Merged
merged 5 commits into from
May 18, 2024
Merged

bump commander to 6.2.0 #16509

merged 5 commits into from
May 18, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 17, 2024

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Bumped commander to 6.2.0, the last version with Node.js 6 support.

@babel-bot
Copy link
Collaborator

babel-bot commented May 17, 2024

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56969

@@ -16,7 +16,7 @@ import type { PluginAPI, PluginObject } from "@babel/core";

const require = createRequire(import.meta.url);

const program = new commander.Command("babel-node");
const program = commander.default.program as commander.Command;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we get the program from the commander default export so that it works for Babel 8 with commander 12.0 as well.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(could you check my slack messages? 😛)

@JLHwung JLHwung merged commit 4f1e42b into babel:main May 18, 2024
51 checks passed
@JLHwung JLHwung deleted the bump-commander branch May 18, 2024 00:52
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants