Rewrite .tsx extension when using rewriteImportExtensions
#16022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55616/ |
jimmydief
commented
Oct 6, 2023
| @@ -16,7 +16,7 @@ export default declare(function ({ types: t }) { | |||
| ? node.importKind | |||
| : node.exportKind; | |||
| if (kind === "value" && source && /[\\/]/.test(source.value)) { | |||
| source.value = source.value.replace(/(\.[mc]?)ts$/, "$1js"); | |||
| source.value = source.value.replace(/(\.[mc]?)tsx?$/, "$1js"); | |||
There was a problem hiding this comment.
Not sure if .mtsx or .ctsx are valid? Seems like no.
There was a problem hiding this comment.
Yeah they are not valid.
liuxingbaoyu
added
the
PR: Polish 💅
nicolo-ribaudo
added
PR: Bug Fix 🐛
nicolo-ribaudo
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
I am a little bit on the fence, since with this PR we would support .tsx but not .jsx. I think we could eventually supports JSX by adding the same option to the react preset if somebody in the future will ask for it (or we could publish extension rewriting as a separate standalone plugin).
nicolo-ribaudo
changed the title
.tsx extension when using rewriteImportExtensions option of TS preset.tsx extension when using rewriteImportExtensions
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
.tsxin the file extensions which are rewritten when usingrewriteImportExtensionsoption of the TS preset.