Use @cspotcode/source-map-support in @babel/register
#16005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
added
the
PR: Polish (next major) 💅
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55987/ |
| import { fileURLToPath } from "url"; | ||
|
|
||
| describe("browserify", function () { | ||
| it("@babel/register may be used without breaking browserify", function () { |
There was a problem hiding this comment.
Can you elaborate more on why this test is not needed anymore?
There was a problem hiding this comment.
The reason why this test was added is that @babel/core previously depended on @babel/register, and we hope that @babel/core can be used in the browser through browserify.
Now that it is no longer relied on, @babel/register itself does not need to be ensured to run in the browser.
There was a problem hiding this comment.
Ok thanks! Could we keep it for Babel 7?
There was a problem hiding this comment.
OK, I'll leave it as a TODO.
There was a problem hiding this comment.
Can also just use itBabel7
liuxingbaoyu
force-pushed
the
register-sourcemap
branch
from
008d8a4 to
001c694
Compare
nicolo-ribaudo
approved these changes
Sep 29, 2023
liuxingbaoyu
force-pushed
the
register-sourcemap
branch
from
82e22a6 to
a1d92d5
Compare
liuxingbaoyu
force-pushed
the
register-sourcemap
branch
from
62504f0 to
67a662b
Compare
JLHwung
approved these changes
Dec 11, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Now we no longer need this test since
@babel/coreno longer depends on it.