[ts] Support private methods overloads #13876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Oct 23, 2021
•
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #13875 |
| Patch: Bug Fix? | Yes |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49364/ |
JLHwung
reviewed
Oct 23, 2021
| @@ -0,0 +1,7 @@ | |||
| class Test { | |||
There was a problem hiding this comment.
TS currently throws when class method is missing implementation. We can use declare class here.
And TS also throws for non-private overload.
class C {
z(): string;
z(): number;
}There was a problem hiding this comment.
It reports the same error for function declarations:
function a(): number;I think we can continue considering this a type-checker level error as we have been doing so far, since it doesn't affect the compiler output in any way.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8e81cf0:
|
JLHwung
approved these changes
Oct 25, 2021
existentialism
approved these changes
Oct 25, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.