convert @babel/helper-module-imports to typescript #12924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2e925fc:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44341/ |
nicolo-ribaudo
added
the
Flow -> TS
JLHwung
reviewed
Mar 1, 2021
| @@ -439,6 +437,7 @@ export default class ImportInjector { | |||
| }); | |||
|
|
|||
| const targetPath = body.find(p => { | |||
| // @ts-expect-error todo(flow->ts): avoid mutations | |||
There was a problem hiding this comment.
TS complains unused '@ts-expect-error' directive here.
There was a problem hiding this comment.
this is because of missing reference to @babel/traverse in tsconfig.json (because traverse types are missing - p instead of NodePath is typed as any, and so there is no error about accessing undeclared property on p.node)
made a fix in #12941
zxbodya
force-pushed
the
ts-migration/babel-helper-module-imports
branch
from
8c6aa6e to
e5c815d
Compare
zxbodya
force-pushed
the
ts-migration/babel-helper-module-imports
branch
from
e5c815d to
2e925fc
Compare
JLHwung
approved these changes
Mar 18, 2021
nicolo-ribaudo
approved these changes
Mar 18, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/helper-module-imports part of #11578