Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking change in @babel/preset-env 7.4.0 #9707

Closed
andreineculau opened this issue Mar 19, 2019 · 4 comments · Fixed by #9709
Closed

breaking change in @babel/preset-env 7.4.0 #9707

andreineculau opened this issue Mar 19, 2019 · 4 comments · Fixed by #9709
Labels
i: bug i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@andreineculau
Copy link

andreineculau commented Mar 19, 2019 •
edited
Loading

Bug Report

Current Behavior
isPluginRequired is not exported anymore from @babel/preset-env

Input Code

let {isPluginRequired} = require('babel-preset-env');

Expected behavior/code

isPluginRequired would be a function, not undefined, with the same signature as before.

Babel Configuration (.babelrc, package.json, cli command)

Environment

Possible Solution

Whether functions like isPluginRequired were intended or not to be exposed is a matter of its own, but such a refactoring should not be done in a minor-version bump.

Additional context/Screenshots
@babel-bot
Copy link
Collaborator

Hey @andreineculau! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

@andreineculau
Copy link
Author

ping @nicolo-ribaudo @zloirock

@zloirock
Copy link
Member

Is this a public API?

@nicolo-ribaudo nicolo-ribaudo mentioned this issue Mar 19, 2019
Merged
@hzoo
Copy link
Member

hzoo commented Mar 19, 2019 •
edited by nicolo-ribaudo
Loading

Ok either way (if we wanted it to be public API or not) that was unintentional to remove a previously exported function. Nicolò made a PR

@ajanssens ajanssens mentioned this issue Mar 19, 2019
Closed
@tobihanl tobihanl mentioned this issue Mar 19, 2019
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
i: bug i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bring back isPluginRequired nicolo-ribaudo/babel
5 participants
@hzoo @andreineculau @zloirock @nicolo-ribaudo @babel-bot