Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-6148 Exclude irrelevant axiom types from validation (9x) #1342

Merged

Conversation

AAAlinaaa
Copy link
Contributor

@AAAlinaaa AAAlinaaa commented Nov 22, 2024

7.x version here: #1343

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark requested a review from apeteri November 22, 2024 14:01
Copy link
Member

@apeteri apeteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

There should also be a faulty GCI expression test which results in a validation issue according to the old code, but no longer creates an issue in the new version.

@cmark
Copy link
Member

cmark commented Nov 25, 2024

@AAAlinaaa please resolve the conflict.

issue/SO-6148-exclude-irrelevant-axiom-types-from-validation-9x
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.70%. Comparing base (820f68d) to head (5f43722).
Report is 26 commits behind head on 9.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1342      +/-   ##
============================================
+ Coverage     63.67%   63.70%   +0.02%     
- Complexity    12523    12530       +7     
============================================
  Files          1612     1613       +1     
  Lines         57120    57207      +87     
  Branches       5622     5628       +6     
============================================
+ Hits          36373    36441      +68     
- Misses        18397    18413      +16     
- Partials       2350     2353       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmark cmark merged commit c783a75 into 9.x Nov 26, 2024
5 checks passed
@cmark cmark deleted the issue/SO-6148-exclude-irrelevant-axiom-types-from-validation-9x branch November 26, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants