-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SO-6148 Exclude irrelevant axiom types from validation (9x) #1342
SO-6148 Exclude irrelevant axiom types from validation (9x) #1342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There should also be a faulty GCI expression test which results in a validation issue according to the old code, but no longer creates an issue in the new version.
@AAAlinaaa please resolve the conflict. |
issue/SO-6148-exclude-irrelevant-axiom-types-from-validation-9x
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 9.x #1342 +/- ##
============================================
+ Coverage 63.67% 63.70% +0.02%
- Complexity 12523 12530 +7
============================================
Files 1612 1613 +1
Lines 57120 57207 +87
Branches 5622 5628 +6
============================================
+ Hits 36373 36441 +68
- Misses 18397 18413 +16
- Partials 2350 2353 +3 ☔ View full report in Codecov by Sentry. |
7.x version here: #1343