Initialize Django module for one-off management commands #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create standard Python packaging artifacts * Move source code over from azavea/open-apparel-registry
* Sketch out test infrastructure with testing artifacts * Add a PR template to the repo
Read configurations for the management command from a settings attribute instead of hardcoding AWS resource names.
Polish up ecsmanage.py management command script to get the module working with OAR.
Set up some simple tests for the package configuration.
Draft basic instructions for setup and development in a README.
* Add .travis.yml for CI * Drop support for py2.7 (EOL in Jan) and py3.5 (f strings)
Squash a bunch of commits designed to appease Travis.
Make sure workarounds for py3.7 and Boto3 testing are documented.
Add additional notes and context to the README.
Make sure the README documents the proper Python support.
* Make sure ecsmanage configures Boto3 clients using the value of AWS_REGION provided by the user * Update ecsmanage.py docstrings
Make sure that the PyPi metadata reflects the correct requirements.
Automatic source code formatting.
hectcastro
reviewed
Apr 6, 2019
There was a problem hiding this comment.
Looks like a great start. Thanks for helping us get this far, @jeancochrane.
rbreslow
force-pushed
the
feature/jrb/init-package
branch
from
69f5ee3 to
cfb5714
Compare
rbreslow
commented
Apr 8, 2019
hectcastro
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Turn the one-off task runner from https://github.com/open-apparel-registry/open-apparel-registry into its own Django module.
When reviewing this PR, take a look at @jeancochrane's comments here.
Closes https://github.com/azavea/operations/issues/296.
Testing instructions
Run app tests
Test the package against OAR
./scripts/manage ecsmanage --env staging helpand confirm that the task gets created as expected