Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ClientIntention over ConnectionProtocol for ClientIntentionPacket #143

Merged
merged 4 commits into from
Apr 27, 2024
Merged

Use ClientIntention over ConnectionProtocol for ClientIntentionPacket #143

merged 4 commits into from
Apr 27, 2024

Conversation

LooFifteen
Copy link
Contributor

@LooFifteen LooFifteen commented Apr 26, 2024 •
edited
Loading

Fixes #142. This is a breaking change, as seen in the tests and examples.

mat-1
mat-1 approved these changes Apr 27, 2024
View reviewed changes
Copy link
Collaborator

@mat-1 mat-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@mat-1 mat-1 merged commit 6553d95 into azalea-rs:main Apr 27, 2024
1 check failed
@LooFifteen LooFifteen deleted the fix/client-intent branch April 27, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-1 mat-1 mat-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClientIntentionPacket incorrectly uses ConnectionProtocol for client intent
2 participants
@LooFifteen @mat-1